Pytest Style analysis/test_nuclinfo.py #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @staticmethod | ||
| @pytest.fixture() | ||
| def u(): |
There was a problem hiding this comment.
can we increase the scope of this fixture?
There was a problem hiding this comment.
@richardjgowers Increase to what level?
|
@richardjgowers Done. Dropped the class too. |
utkbansal
changed the title
jbarnoud
requested changes
Jul 26, 2017
| def test_minor_pair_2(self): | ||
| val = nuclinfo.minor_pair(self.u, 20, 5, seg1='RNAA', seg2='RNAA') | ||
| assert_almost_equal(val, 4.356, decimal=3) | ||
| def test_minor_pair_1(u): |
There was a problem hiding this comment.
test_minor_pair_1 and test_minor_pair_2 can be grouped in a parametrized test_minor_pair.
| def test_phase_cp_2(self): | ||
| val = nuclinfo.phase_cp(self.u, seg='RNAA', i=21) | ||
| assert_almost_equal(val, 16.199, decimal=3) | ||
| def test_major_pair_1(u): |
There was a problem hiding this comment.
test_major_pair_* can be grouped in a parametrized test.
jbarnoud
approved these changes
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes made in this Pull Request:
PR Checklist