New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review Needed]Pytest Style coordinates/test_chainreader.py #1640

Merged
merged 2 commits into from Aug 24, 2017

Conversation

Projects
None yet
2 participants
@utkbansal
Copy link
Member

utkbansal commented Aug 21, 2017

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@pytest.fixture()
def trajectory(self, universe):
return universe.trajectory

This comment has been minimized.

@kain88-de

kain88-de Aug 22, 2017

Member

please remove this fixture and use universe.trajectory directly in the tests


class TestChainReaderCommonDt(TestCase):
def setUp(self):

This comment has been minimized.

@kain88-de

kain88-de Aug 22, 2017

Member

why does this class still have a setup method?

@kain88-de kain88-de merged commit f08aa4f into MDAnalysis:develop Aug 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.603%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment