[Review Needed]Pytest Style coordinates/test_chainreader.py#1640
Merged
kain88-de merged 2 commits intoMDAnalysis:developfrom Aug 24, 2017
Merged
[Review Needed]Pytest Style coordinates/test_chainreader.py#1640kain88-de merged 2 commits intoMDAnalysis:developfrom
kain88-de merged 2 commits intoMDAnalysis:developfrom
Conversation
kain88-de
requested changes
Aug 22, 2017
|
|
||
| @pytest.fixture() | ||
| def trajectory(self, universe): | ||
| return universe.trajectory |
Member
There was a problem hiding this comment.
please remove this fixture and use universe.trajectory directly in the tests
| return universe.trajectory | ||
|
|
||
| class TestChainReaderCommonDt(TestCase): | ||
| def setUp(self): |
Member
There was a problem hiding this comment.
why does this class still have a setup method?
kain88-de
approved these changes
Aug 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes made in this Pull Request:
PR Checklist