Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: skip gsd-based tests on Windows #1914

Merged
merged 1 commit into from
May 30, 2018
Merged

Conversation

tylerjereddy
Copy link
Member

As far as I can tell our gsd dependency is not Windows compatible so I've marked the corresponding unit tests for skipping based on platform.

If we agree that gsd isn't windows compatible, there's probably also some kind of documentation or warning related to import that might be suitable.

@tylerjereddy
Copy link
Member Author

I noticed tracebacks in the gsd source that used i.e., a / explicitly in a path setting code instead of something like os.path.join(), so the compatibility fixes on their end might not be that difficult, but I think is outside our remit beyond possibly raising an issue with them if possible / appropriate.

@orbeckst
Copy link
Member

orbeckst commented May 24, 2018

Please raise an issue with gsd.

But I think that instead of skipping GSD tests per se, we should have something in our GSD reader that fails gracefully under Windows and then test that it does fail nicely.

EDIT: I guess you'll still need the "skip GSD tests under NT" but this still leaves the main code open to a bad user experience with GSD under Windows.

@tylerjereddy
Copy link
Member Author

I've opened the issue on their bitbucket in any case.

@richardjgowers richardjgowers mentioned this pull request May 30, 2018
@richardjgowers richardjgowers merged commit 347f60f into develop May 30, 2018
@richardjgowers richardjgowers deleted the windows_skip_gsd_tests branch May 30, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants