Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests and updated docs for analysis.data #2047

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

orbeckst
Copy link
Member

Updates to the merged PR #2033, which introduced a data section for analysis

  • add docs explaining data and showing example use
  • simple test for loading all data in analysis.data.filenames (analysis/test_data.py)
  • replaced assert_array_equal with assert_equal in utils/test_datafiles.py, which I used
    as a template

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

- add docs explaining data and showing example use
- simple test for loading all data in analysis.data.filenames (analysis/test_data.py)
- replaced assert_array_equal with assert_equal in utils/test_datafiles.py, which I used
  as a template
@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #2047 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2047   +/-   ##
========================================
  Coverage    88.93%   88.93%           
========================================
  Files          144      144           
  Lines        17490    17490           
  Branches      2693     2693           
========================================
  Hits         15554    15554           
  Misses        1323     1323           
  Partials       613      613
Impacted Files Coverage Δ
package/MDAnalysis/analysis/data/filenames.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e22ff...c80ba62. Read the comment docs.

@orbeckst
Copy link
Member Author

I can't think of anything else to do on this branch, at least for right now. Please feel free to review and merge.

@richardjgowers richardjgowers merged commit 825ee05 into develop Aug 16, 2018
@IAlibay IAlibay deleted the analysis-data-test-docs branch May 29, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants