Sp box

[zemanj]

Fixes #2190

Changes made in this Pull Request:

• Enforced dtype=numpy.float32 for Universe.dimensions and Timestep.dimensions

I searched the code base and found the same lines as indicated by @jbarnoud and @PicoCentauri in the discussion of #2190 (see comments of @jbarnoud and @PicoCentauri).

No calls of numpy.astype() to make @richardjgowers happy. 😉

Checks for valid boxes as outlined in my comment are not included since that requires a more in-depth discussion about what defines a valid box (semi-periodic systems, negative angles, etc.).

I don't think we need to adjust the docs, right?

PR Checklist

• Tests?
• Docs?
• CHANGELOG updated?
• Issue raised/referenced?

[zemanj]

@richardjgowers Thanks, that was record-breaking fast! 👍

[codecov]

Codecov Report

Merging #2213 into develop will decrease coverage by 1.14%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2213      +/-   ##
===========================================
- Coverage    90.71%   89.57%   -1.15%     
===========================================
  Files           15      158     +143     
  Lines         1982    19684   +17702     
  Branches         0     2769    +2769     
===========================================
+ Hits          1798    17631   +15833     
- Misses         184     1458    +1274     
- Partials         0      595     +595

Impacted Files	Coverage Δ
package/MDAnalysis/core/universe.py	94.98% <100%> (ø)
package/MDAnalysis/coordinates/memory.py	96.02% <100%> (ø)
package/MDAnalysis/coordinates/GRO.py	93.87% <0%> (ø)
package/MDAnalysis/coordinates/base.py	93.3% <0%> (ø)
package/MDAnalysis/analysis/helanal.py	85.19% <0%> (ø)
package/MDAnalysis/topology/MinimalParser.py	100% <0%> (ø)
package/MDAnalysis/visualization/__init__.py	100% <0%> (ø)
package/MDAnalysis/core/qcprot.py	100% <0%> (ø)
...e/MDAnalysis/analysis/encore/clustering/cluster.py	96.22% <0%> (ø)
package/MDAnalysis/coordinates/DCD.py	97.16% <0%> (ø)
... and 135 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddab79e...60c7a66. Read the comment docs.