Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards #2468 (RDKit interoperability GSOC project) #2916

Merged
merged 1 commit into from
Aug 23, 2020
Merged

Commits on Aug 22, 2020

  1. Towards #2468 (RDKit interoperability GSOC project)

    * Overview of work done in PR
    
      This PR adds the `RDKitConverter` class which converts MDAnalysis
      `Universe`/`Atomgroup` objects to `RDKit rdchem.Mol` objects.
    
    * Limitations
      - Bonds and elements must be present (the former will be inferred if not
        present).
      - This converter mainly aims at supporting cases where explicit hydrogens
        are present.
    
    * Extra implementation details
      - Bond order and formal charges are inferred via atomic valencies & the
        number of unpaired electrons (see `_infer_bo_and_charges`).
      - In part due to the influence of atom read order on inferring, bond
        conjugation and functional groups are standardized using SMARTS
        reactions (see `_standardize_patterns`).
    
    *  Other changes
    
       Also includes some PEP8 changes and some cleaning up of the tests for the
       `RDKITReader`.
    
    * References
      For more information on the development process for this PR, see:
      1) https://cbouy.github.io/blog/2020/07/01/rdkit-converter
      2) https://cbouy.github.io/blog/2020/07/22/rdkit-converter-part2
    Cédric Bouysset authored and orbeckst committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    9ebc1b2 View commit details
    Browse the repository at this point in the history