-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No need to redirect to the original frame explicitly during deserialization #3722
Open
yuxuanzhuang
wants to merge
22
commits into
MDAnalysis:develop
Choose a base branch
from
yuxuanzhuang:opt_serialization
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
6a667f6
serialize without visit ts
yuxuanzhuang a8a5485
add double pickling test
yuxuanzhuang b358bd2
offset should be the same
yuxuanzhuang 5b035fc
add comment about bufferio
yuxuanzhuang b186584
doc
yuxuanzhuang b1a3770
merge to dev
yuxuanzhuang 8fda4ef
merge to dev
yuxuanzhuang bef41aa
Merge remote-tracking branch 'mda_origin/develop' into opt_serialization
yuxuanzhuang 917dc65
add changelog
yuxuanzhuang bd553c1
add test for preservation of coord after serialization
yuxuanzhuang 884a795
fix h5md setstate
yuxuanzhuang 8535692
fix h5md comments
yuxuanzhuang bce27a3
merge to dev
yuxuanzhuang 8a1222a
merge to dev
yuxuanzhuang dc40dd6
merge to dev
yuxuanzhuang 35354be
Merge branch 'develop' into opt_serialization
orbeckst f6d5716
fixed CHANGELOG
orbeckst 5b6b521
more CHANGELOG fixes
orbeckst f3cc8d3
Apply suggestions from code review
orbeckst 845dede
tng setstate
yuxuanzhuang ff31fc9
Merge branch 'develop' into opt_serialization
yuxuanzhuang 1a6272e
pep8
yuxuanzhuang File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,8 @@ The rules for this file: | |
|
||
------------------------------------------------------------------------------- | ||
??/??/?? IAlibay, ianmkenney, PicoCentauri, pgbarletta, p-j-smith, | ||
richardjgowers, lilyminium, ALescoulie, hmacdope, HeetVekariya | ||
richardjgowers, lilyminium, ALescoulie, hmacdope, HeetVekariya, | ||
yuxuanzhuang | ||
|
||
* 2.7.0 | ||
|
||
|
@@ -48,6 +49,8 @@ Enhancements | |
(Issue #3994, PR #4281) | ||
* Add support for reading chainID info from Autodock PDBQT files (Issue #4207, | ||
PR #4284) | ||
* Improve performance in Universe serialization by no explicit redirection to | ||
the timestep. (Issue #3721, PR #3722) | ||
|
||
Changes | ||
* Biopython is now an optional dependency (Issue #3820, PR #4332) | ||
|
@@ -198,6 +201,10 @@ Fixes | |
* Fix MSD docs to use the correct error metric in example (Issue #3991) | ||
* Add 'PairIJ Coeffs' to the list of sections in LAMMPSParser.py | ||
(Issue #3336) | ||
* Fix failure in double-serialization of TextIOPicklable file reader. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. |
||
(Issue #3723, PR #3722) | ||
* Fix failure to preserve modification of coordinates after serialization. | ||
(Issue #3723, PR #3722) | ||
|
||
Enhancements | ||
* ARM64 (osx and linux) wheels now uploaded on release (Issue #4054) | ||
|
@@ -364,6 +371,8 @@ Changes | |
use `pip install ./package[extra_formats]` instead (PR #3810) | ||
* `Universe.empty` emmits less warnings (PR #3814) | ||
* adding element attribute to TXYZParser if all atom names are valid element symbols (PR #3826) | ||
* TextIOPicklable serializes the raw class instance instead of class name. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. |
||
(PR #3722) | ||
|
||
Deprecations | ||
* Direct indexing of results in analysis.nucleicacids' NucPairDist | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newest first :)