-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix contourpy install for 32bit azure runner and pin GSD #4171
Conversation
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #4171 +/- ##
===========================================
+ Coverage 85.57% 93.60% +8.02%
===========================================
Files 179 193 +14
Lines 24027 25147 +1120
Branches 3468 4056 +588
===========================================
+ Hits 20562 23539 +2977
+ Misses 2989 1092 -1897
- Partials 476 516 +40 ☔ View full report in Codecov by Sentry. |
Do we know how much 32 bit is actually being used? What is the position of numpy/scipy on 32 bit support, @tylerjereddy ? Ending support for 32 bit for 3.0 sounds sensible. I think one thing we should discuss at our next meeting is a tentative roadmap. |
Also, where do we use contourpy? Is that a secondary dependency? |
It's a dependency for matplotlib. |
🤦🏽 of course.. of course GSD releases a new version when I'm trying to debug something else |
SciPy has stopped providing 32-bit Windows wheels on PyPI (we also switched to There's some discussion here: So, current SciPy stable releases have neither Windows nor Linux 32-bit binaries. Current NumPy stable release has no 32-bit binaries for Linux, but does have 32-bit binaries for Windows because they haven't swapped to Anyway, I guess that's a long way of saying that it seems like support has decreased for 32-bit binaries, though we do still at least try to test in CI when it is possible, but the priority overall seems to have dropped a bit I'd say (I think Debian and/or other Linux distros dropping official 32-bit support also forced NumPy's hand a bit on Linux, which then forced our hand too I think..). |
Might just be time to banish 32 but ASAP. |
@MDAnalysis/coredevs this is good to go - it'll unblock CI for now. |
1.1.0 of contourpy was released 3 days ago and it's making the 32 bit runner fail (they switched over to meson builds, so no more x86).
We're really pushing it in terms of how many bandaids we can put on to test 32bit support.... @MDAnalysis/coredevs we need to start discussing if we want to drop 32bit ahead of the 3.0 release.
Changes made in this Pull Request:
PR Checklist
📚 Documentation preview 📚: https://mdanalysis--4171.org.readthedocs.build/en/4171/