Partial Fix: groups.py doctest error #4519
Conversation
The error lead to difference between expected and obtained output, since the obtained Ouput lacked dtype=int64, which was present in the expected Output this part was removed to make the expected Output fit the obtained Output
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.
Linter Bot Results:Hi @talagayev! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4519 +/- ##
===========================================
- Coverage 93.65% 93.63% -0.03%
===========================================
Files 168 180 +12
Lines 21215 22294 +1079
Branches 3908 3908
===========================================
+ Hits 19869 20875 +1006
- Misses 888 961 +73
Partials 458 458 ☔ View full report in Codecov by Sentry. |
|
This PR may be a duplicate of PR #4374 . We'll first have to finalize the other PR and then we will see if there's anything else to be done. |
|
Leave it open for now. I can close it if/when the other PR gets merged. |
|
Given that the prior PR #4374 was merged and addresses the original issue, I am just closing this PR. Thanks for the work @talagayev , sorry that it's not going in. |
It's fine, my mistake that i didn't notice that PR #4374 already adressed the issue. |
Partially addresses #3925
group.pydoctest errorsChanges made in this Pull Request:
Doctest for groups.py. Five instances of errors occure in regards to difference between the expected output and obtained output during use of examples using
.ixwith the expected output dispayingdtype=int64not present in obtained output. Example of previous expected output:Corrected expected output according to the generated output as below:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4519.org.readthedocs.build/en/4519/