-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip observables contained in particle groups #4615
Open
PythonFZ
wants to merge
20
commits into
MDAnalysis:develop
Choose a base branch
from
PythonFZ:h5md-skip-per-particles-observables
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−12
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
f9c6ca1
skip observables contained in particle groups
PythonFZ 078d168
format only relevant lines
PythonFZ c5d2db2
remove whitespace
PythonFZ bbf4f20
Update AUTHORS
PythonFZ bccda1c
address comments
PythonFZ 5376223
Merge branch 'h5md-skip-per-particles-observables' of https://github.…
PythonFZ b22869f
add test: open file
PythonFZ e9b4353
Return Universe
PythonFZ e86e475
move tested method into the scope of the test
PythonFZ 7d5eb1c
update CHANGELOG
PythonFZ 19035f5
fix order
PythonFZ 87b23d7
add GitHub username
PythonFZ 1cfedf4
address comments
PythonFZ de7e7ba
lint
PythonFZ 757f850
address comments
PythonFZ 1d1b3df
rename file
PythonFZ f52b644
Merge remote-tracking branch 'origin/develop' into h5md-skip-per-part…
PythonFZ 3ae0f26
line length
PythonFZ 225a7aa
format
PythonFZ 6faa14d
white space
PythonFZ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should issue a warning that observables of the form
observables/group1/observable1
are being ignored if present.