Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate fetch mmtf #4639

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Deprecate fetch mmtf #4639

merged 5 commits into from
Jul 24, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jul 22, 2024

Fixes #4634

Changes made in this Pull Request:

  • Remove fetch_mmtf method
  • Deprecate MMTFReader

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4639.org.readthedocs.build/en/4639/

@pep8speaks
Copy link

pep8speaks commented Jul 22, 2024

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 60:80: E501 line too long (83 > 79 characters)

Comment last updated at 2024-07-24 14:17:41 UTC

Copy link

github-actions bot commented Jul 22, 2024

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ⚠️ Possible failure
testsuite ✅ Passed

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/10078393665/job/27863215540


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (b227f17) to head (42841e8).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4639      +/-   ##
===========================================
- Coverage    93.61%   93.59%   -0.03%     
===========================================
  Files          171      183      +12     
  Lines        21250    22320    +1070     
  Branches      3936     3937       +1     
===========================================
+ Hits         19893    20890     +997     
- Misses         898      971      +73     
  Partials       459      459              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member Author

IAlibay commented Jul 22, 2024

RDKit failures being fixed in #4640

Copy link
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content LGTM @IAlibay

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orbeckst
Copy link
Member

@RMeli or @IAlibay please merge when you need to. If there's a reason not merge leave a comment, please.

@RMeli
Copy link
Member

RMeli commented Jul 24, 2024

@orbeckst CI is not in a good state. There was one of the usual timeouts, but I think this PR is blocked by #4640.

@RMeli RMeli merged commit 780f958 into develop Jul 24, 2024
22 of 23 checks passed
@RMeli RMeli deleted the deprecate-fetch_mmtf branch July 24, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fetch_mmtf no longer works
5 participants