Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define grid size for different box shapes. #35

Closed
2 tasks
ojeda-e opened this issue Jun 25, 2021 · 2 comments
Closed
2 tasks

Define grid size for different box shapes. #35

ojeda-e opened this issue Jun 25, 2021 · 2 comments
Assignees
Labels
refactoring code rewrites without functional changes testing testing framework

Comments

@ojeda-e
Copy link
Member

ojeda-e commented Jun 25, 2021

As pointed out by @orbeckst, after initial refactor in #34 the grid is assumed to be square. The grid should accept at least rectangular shapes.

To do:

  • Define the size of the grid by at least x and y.
    Suggestion: box_size = max(u.dimensions[0], u.dimensions[1])
  • Add xfail for orhtorombic/triclinic box.
@ojeda-e ojeda-e added testing testing framework refactoring code rewrites without functional changes labels Jun 25, 2021
@ojeda-e ojeda-e self-assigned this Jun 25, 2021
@ojeda-e ojeda-e changed the title Define grid size for Define grid size for different box shapes. Jun 25, 2021
@ojeda-e
Copy link
Member Author

ojeda-e commented Jul 24, 2021

I think we I can close this issue since we have
self.x_range = x_range if x_range else (0, universe.dimensions[0])
self.y_range = y_range if y_range else (0, universe.dimensions[1])

in base.py and respective tests with rectangular box sizes.

Do you agree @orbeckst @IAlibay @lilyminium ? Am I missing something here? Thanks.

@lilyminium
Copy link
Member

If you add a rectangular grid test then yeah I think this is covered!

@ojeda-e ojeda-e closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring code rewrites without functional changes testing testing framework
Projects
None yet
Development

No branches or pull requests

2 participants