Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated logger.warn - deprecation warning #102

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Updated logger.warn - deprecation warning #102

merged 2 commits into from
Oct 20, 2022

Conversation

ojeda-e
Copy link
Member

@ojeda-e ojeda-e commented Oct 19, 2022

Description

Since we are postponing the release, this PR fixes #96 and some typos in the docs before I keep forgetting.

Status

  • Ready to go

@ojeda-e ojeda-e requested a review from IAlibay October 19, 2022 19:11
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #102 (19ca23d) into main (b919476) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

IAlibay
IAlibay approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ojeda-e ojeda-e merged commit 95a8c57 into main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAlibay IAlibay IAlibay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warning in base
2 participants
@ojeda-e @IAlibay