Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py311 to CI and towards NEP29 #103

Merged
merged 17 commits into from
Nov 2, 2022
Merged

Add py311 to CI and towards NEP29 #103

merged 17 commits into from
Nov 2, 2022

Conversation

ojeda-e
Copy link
Member

@ojeda-e ojeda-e commented Oct 19, 2022

Description

Fixes #101

Changes

  • Bumped actions version in CI.
  • Bumped python version in minimum_requirements CI.
  • Bumped numpy and MDA versions in setup.py.
  • Bumped python_requires to 3.8 in setup.py.
  • Added upstream_develop job in CI for Python 3.10 and 3.11.

Status

  • Ready to go

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #103 (bc0ad5c) into main (b919476) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@ojeda-e ojeda-e changed the title Added py311rc2 to CI Python matrix Added py311rc2 to CI Oct 19, 2022
.github/workflows/CI.yaml Outdated Show resolved Hide resolved
@ojeda-e ojeda-e requested a review from IAlibay October 20, 2022 01:17
@ojeda-e
Copy link
Member Author

ojeda-e commented Oct 25, 2022

@IAlibay can I have a review here, please?

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I'd add 3.11 to the classifiers list

.github/workflows/CI.yaml Outdated Show resolved Hide resolved
.github/workflows/CI.yaml Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
.github/workflows/CI.yaml Outdated Show resolved Hide resolved
@ojeda-e ojeda-e changed the title Added py311rc2 to CI Add py311 to CI and towards NEP29 Oct 25, 2022
@ojeda-e ojeda-e requested a review from IAlibay October 26, 2022 00:56
@ojeda-e
Copy link
Member Author

ojeda-e commented Oct 26, 2022

Thanks for your help and patience here @IAlibay. It is ready for review.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

The build times seem a bit long (~ 3-5 mins vs 1s of tests), it might be worth playing around with the mamba options for conda-incubator/setup-miniconda to see if that can be improved.

strategy:
fail-fast: false
matrix:
latest-python : ["3.10", "3.11"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "latest" seems a bit odd here, but it's not exactly a big deal.

@IAlibay
Copy link
Member

IAlibay commented Nov 2, 2022

it might be worth playing around with the mamba options for conda-incubator/setup-miniconda to see if that can be improved.

Possibly a separate issue, but this might actually be one of those few cases where just using pip to install everything could be faster? (i.e. the benefits of conda might not be that worth it)

@ojeda-e ojeda-e merged commit 4378d00 into main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 3.11 to CI
3 participants