-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add py311 to CI and towards NEP29 #103
Conversation
@IAlibay can I have a review here, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I'd add 3.11 to the classifiers list
Thanks for your help and patience here @IAlibay. It is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The build times seem a bit long (~ 3-5 mins vs 1s of tests), it might be worth playing around with the mamba
options for conda-incubator/setup-miniconda
to see if that can be improved.
strategy: | ||
fail-fast: false | ||
matrix: | ||
latest-python : ["3.10", "3.11"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word "latest" seems a bit odd here, but it's not exactly a big deal.
Possibly a separate issue, but this might actually be one of those few cases where just using |
Description
Fixes #101
Changes
minimum_requirements
CI.setup.py
.python_requires
to 3.8 insetup.py
.upstream_develop
job in CI for Python 3.10 and 3.11.Status