Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIx CI #112

Merged
merged 18 commits into from
Dec 19, 2023
Merged

FIx CI #112

merged 18 commits into from
Dec 19, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 27, 2023 •
edited

Description

  • Fixes codecov failing cron CI because of being called too many times
  • Adds 3.11 CI
  • Adds 3.12 to upstream CI
  • Drop Python 3.8
  • Add all necessary bits to support Python 3.12 ahead of next MDA release.
  • Fix RTD builds
  • Switch CI conda install to micromamba

Status

  • Ready to go

@IAlibay
FIx CI
8074367 
* Fixes codecov failing cron CI because of being called too many times
* Adds 3.11 CI
* Adds 3.12 to upstream CI
@IAlibay
Update and rename readthedocs.yml to .readthedocs.yml
3ef00f4
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited

Codecov Report

Merging #112 (d2cf8d5) into main (0cf4856) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

🤦🏽‍♂️ I accidentally pushed the update to versioneer to main rather than this branch.

It's effectively just the outcome of calling versioneer install with 0.29, and would have been included in this PR instead.

I hope this is reasonable? Otherwise I'll try to see if I can remove that commit.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

I've run out of velocity in trying to fix this for now - there's something breaking both rtd and py3.9, not sure why right now.

@lilyminium lilyminium mentioned this pull request Oct 27, 2023
Closed
@pep8speaks
Copy link

pep8speaks commented Oct 28, 2023 •
edited

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1:1: W391 blank line at end of file

Comment last updated at 2023-12-19 18:32:03 UTC

@IAlibay IAlibay requested a review from ojeda-e October 28, 2023 20:11
@IAlibay
Copy link
Member Author

IAlibay commented Oct 28, 2023

Ok this shoudl be good to go.

RMeli
RMeli reviewed Oct 28, 2023
View reviewed changes
.github/workflows/CI.yaml
- name: Install package
# conda setup requires this special shell
shell: bash -l {0}
run: |
python -m pip install . --no-deps
conda list
pip list
micromamba list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
micromamba list

Is this necessary? As far as I can tell, micromamba list is run for the setup micromamba step already.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm keeping the spirit of what the original CI file did (there was a conda list call here).

Generally having a step post install that tells you everything in the environment is a good idea though - it tells you if anything has changed through pip override

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, good point!

@IAlibay
Copy link
Member Author

IAlibay commented Oct 29, 2023

Thanks for the review @RMeli - looks like we aren't set as maintainers for this repo though :(

Indeed who is meant to maintain this repo is unclear to me - this is a discussion we will need to have with @ojeda-e.

@RMeli
Copy link
Member

RMeli commented Oct 30, 2023

Always sad to see a grey check. =P Indeed, that is a discussion to be had with @ojeda-e and the GSoC mentors.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 30, 2023

There's a deeper conversation we need to have about what we (coredevs) actually maintain in the org.

@IAlibay IAlibay closed this Dec 19, 2023
@IAlibay IAlibay reopened this Dec 19, 2023
@IAlibay
Copy link
Member Author

IAlibay commented Dec 19, 2023

We will merge this without defined maintainer review to keep CI green. Thanks @RMeli for reviewing.

@IAlibay IAlibay merged commit 5d2de99 into main Dec 19, 2023
30 checks passed
@IAlibay IAlibay deleted the fix-ci branch December 19, 2023 23:23
This was referenced Dec 19, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMeli RMeli RMeli approved these changes

@ojeda-e ojeda-e Awaiting requested review from ojeda-e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@IAlibay @pep8speaks @RMeli @lilyminium