Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix doc things #59

Merged
merged 2 commits into from Jul 30, 2021
Merged

fix doc things #59

merged 2 commits into from Jul 30, 2021

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented Jul 28, 2021 •
edited

Description

  • fix link to GPL v3 in docs
  • fix math type setting mean curvature

@orbeckst orbeckst requested a review from ojeda-e July 28, 2021 23:05
@codecov
Copy link

codecov bot commented Jul 28, 2021 •
edited

Codecov Report

Merging #59 (8b0a864) into main (c97fb9e) will not change coverage.
The diff coverage is n/a.

@IAlibay
Copy link
Member

IAlibay commented Jul 28, 2021

Note, setup.py claims MIT, probably worth checking for consistency in the license.

@orbeckst orbeckst changed the title fix GPLv3 link docs fix doc things Jul 28, 2021
@orbeckst
Copy link
Member Author

setup.py needs changing

@orbeckst
Copy link
Member Author

Well, the LICENSE file is MIT https://github.com/MDAnalysis/membrane-curvature/tree/fix-license-link ... I'll raise a issue.

@orbeckst orbeckst mentioned this pull request Jul 28, 2021
Closed
ojeda-e
ojeda-e reviewed Jul 30, 2021
View reviewed changes
membrane_curvature/curvature.py
@@ -15,7 +15,7 @@
Mean curvature is defined by

.. math:: H =
\frac{(1+\partial_x^2)\partial_{yy}+(1+\partial_y^2)\partial_{xx}-2\partial_x\partial_y\partial{xy}}
\frac{(1+\partial_x^2)\partial_{yy}+(1+\partial_y^2)\partial_{xx}-2\partial_x\partial_y\partial_{xy}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, that's a hard one to spot.

ojeda-e
ojeda-e approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@ojeda-e ojeda-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orbeckst
Copy link
Member Author

orbeckst commented Jul 30, 2021 via email

@ojeda-e ojeda-e merged commit 67dae7f into main Jul 30, 2021
@ojeda-e ojeda-e deleted the fix-license-link branch August 29, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojeda-e ojeda-e ojeda-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orbeckst @IAlibay @ojeda-e