Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added logger to surface warning messages. #83

Merged
merged 1 commit into from
Oct 2, 2021
Merged

Added logger to surface warning messages. #83

merged 1 commit into from
Oct 2, 2021

Conversation

ojeda-e
Copy link
Member

@ojeda-e ojeda-e commented Oct 1, 2021

Fixes #79

Changes include:

  • Added logger to warning messages in surface.py when atoms fall outside boundaries.
  • Updated message to provide more informations.
  • Added tests to raise warning messages using negative coordinates.
  • Added tests to raise warning messages using (too large) positive coordinates.

Thanks @orbeckst for pointing this out in previous reviews. Tagging also @lilyminium in case she's available to check this PR.

To start, will assign @hmacdope as a reviewer.

Thanks!

@ojeda-e ojeda-e requested a review from hmacdope October 1, 2021 18:20
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #83 (b329b4f) into main (f2c4e19) will not change coverage.
The diff coverage is 100.00%.

hmacdope
hmacdope approved these changes Oct 2, 2021
View reviewed changes
Copy link
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @ojeda-e! Clean and simple.

@ojeda-e ojeda-e merged commit 0701138 into main Oct 2, 2021
@ojeda-e ojeda-e deleted the issue79 branch October 2, 2021 23:44
@ojeda-e ojeda-e mentioned this pull request Oct 19, 2021
Closed
@ojeda-e ojeda-e mentioned this pull request Oct 13, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmacdope hmacdope hmacdope approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning messages not logged
2 participants
@ojeda-e @hmacdope