Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten module organization - remove analysis folder #22

Merged
merged 4 commits into from Jul 3, 2023
Merged

Flatten module organization - remove analysis folder #22

merged 4 commits into from Jul 3, 2023

Conversation

xhgchen
Copy link
Collaborator

@xhgchen xhgchen commented Jul 1, 2023 •
edited

Fixes #21

Changes made in this Pull Request:

  • Move all analysis modules up a directory
  • Update codecov.yml
  • Update path for docs
  • Move tests up a directory
  • Delete analysis folders
  • Update imports to use transport_analysis.module_name instead of transport_analysis.analysis.module_name

hmacdope
hmacdope requested changes Jul 1, 2023
View reviewed changes
Copy link
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to change imports in tests to match new structure

@xhgchen
Remove analysis folder and update Codecov
c8cf8d7 
* Move all analysis modules up a directory
* Update `codecov.yml`
* Update path for docs
@xhgchen
Remove analysis folder in tests
4e0e2b3 
* Move `test_velocityautocorr.py` up a directory
@xhgchen
Update import in test_velocityautocorr.py
1b5e81b
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #22 (561efbe) into main (f305af4) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

@xhgchen xhgchen changed the title Remove analysis folder and update Codecov Flatten module organization - remove analysis folder Jul 3, 2023
@xhgchen xhgchen requested a review from hmacdope July 3, 2023 00:10
hmacdope
hmacdope approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xhgchen xhgchen merged commit 45dd445 into MDAnalysis:main Jul 3, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmacdope hmacdope hmacdope approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flatten module organization
2 participants
@xhgchen @hmacdope