Fix lwip implementation to use appropriate type for timeouts for socket options setting #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To avoid similar problems we should specify the options in the API, see: #8 |
0xc0170
reviewed
May 9, 2022
| if (rc == 0) { | ||
| sock_attr[socket-LWIP_SOCKET_OFFSET].tv_sec = *(const uint32_t *)opt_val / 1000U; | ||
| sock_attr[socket-LWIP_SOCKET_OFFSET].tv_msec = *(const uint32_t *)opt_val % 1000U; | ||
| case IOT_SOCKET_SO_SNDTIMEO: ; /* do not remove the semi-colon */ |
There was a problem hiding this comment.
I would add to the commit message the intention with ; being placed here. It's important detail why are we doing this.
The semicolon is needed after the label because the langage spec forbids non-code statements following directly after a label (causing compile error)
|
I added a comment in the commit message |
RobertRostohar
added a commit
that referenced
this pull request
Jul 8, 2022
|
The commit (3188c55) should properly fix the lwIP implementation. Pleas check and close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API specifies an int of ms but lwip can also use timeval based on build options. This translates the values between implementation and API.