Bug in data alignment. #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfredian
force-pushed
the
twf-fix-pointer-alignment
branch
from
40630ff
to
bc79dcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alignment macro used for aligning data when copying descriptors to a descriptor_xd produced undefined behavior because of incorrect used of parenthesis. This problem did not show up on any of gcc sanitize checkers and apparently only produced a problem with 64-bit builds for Windows. Even then it did not cause any problem except when MDSplus was used with Anaconda python 3.5 where it produced access violations.
This should fix #675 and #310 .
Very strange that it only seemed to show up with Anaconda python version 3.5 on Windows.