Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document decision tree steps in report #959

Merged
merged 30 commits into from
Feb 21, 2024
Merged
Changes from 3 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
b50cb4e
Add comments to the minimal decision tree.
tsalo Aug 3, 2023
4d0a141
Improve comments.
tsalo Aug 3, 2023
eb4d341
Move from comments to log_extra_report.
tsalo Aug 3, 2023
d5c5b38
Add comments and fix one description.
tsalo Aug 3, 2023
61476e8
Update minimal.json
tsalo Aug 3, 2023
05d70f7
Retain artifacts.
tsalo Aug 3, 2023
b7886fe
Store correct artifact path.
tsalo Aug 3, 2023
62dc400
Test minimal decision tree.
tsalo Aug 3, 2023
7c7517f
Add newlines.
tsalo Aug 3, 2023
d35cfe6
Update tedana.py
tsalo Aug 3, 2023
daae14d
Update tedana.py
tsalo Aug 3, 2023
cb55ddd
Keep documenting the trees.
tsalo Aug 3, 2023
9e41d92
Update minimal.json
tsalo Aug 3, 2023
3d9f9fc
Fix decision tree description.
tsalo Aug 3, 2023
b10b70a
Merge remote-tracking branch 'upstream/main' into doc-tree
tsalo Aug 11, 2023
a500b05
Merge remote-tracking branch 'upstream/main' into doc-tree
tsalo Aug 12, 2023
f92d600
Document the remaining nodes in the kundu tree.
tsalo Aug 12, 2023
9b391e3
Fix manrej typo.
tsalo Aug 28, 2023
044e223
Cite Olafsson paper for decision tree nodes.
tsalo Sep 8, 2023
3ce5aca
Merge branch 'ME-ICA:main' into doc-tree-dh
handwerkerd Oct 12, 2023
5d0947d
updated minimal.json and started references.bib
handwerkerd Oct 20, 2023
b9aaa5d
Merge 'upstream/main' into doc-tree-dh
handwerkerd Oct 27, 2023
3875ea7
Merge branch 'main' into doc-tree
tsalo Oct 30, 2023
7a6895c
aligning to main again
handwerkerd Nov 1, 2023
7cee859
test-component_selector
handwerkerd Nov 1, 2023
262f62b
Merge branch 'doc-tree' into doc-tree-dh
tsalo Feb 3, 2024
2e4f290
Merge pull request #12 from handwerkerd/doc-tree-dh
tsalo Feb 3, 2024
ded2abe
Merge remote-tracking branch 'upstream/main' into doc-tree-dh
handwerkerd Feb 20, 2024
8d4195b
Merge pull request #15 from handwerkerd/doc-tree-dh
tsalo Feb 20, 2024
fb4c290
Merge remote-tracking branch 'upstream/main' into doc-tree
tsalo Feb 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 49 additions & 26 deletions tedana/resources/decision_trees/minimal.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,12 @@
"decide_comps": "all"
},
"kwargs": {
"log_extra_report": "",
"log_extra_info": "",
"log_extra_report": "All components are initially labeled as 'unclassified'.",
"clear_classification_tags": true,
"dont_warn_reclassify": true
}
},
"_comment": ""
},
{
"functionname": "dec_left_op_right",
Expand All @@ -46,9 +48,11 @@
"right": "kappa"
},
"kwargs": {
"log_extra_report": "",
"log_extra_info": "",
"log_extra_report": "Any components with rho greater than kappa are rejected.",
"tag_if_true": "Unlikely BOLD"
}
},
"_comment": ""
},
{
"functionname": "dec_left_op_right",
Expand All @@ -64,17 +68,24 @@
"left2": "countsigFT2",
"op2": ">",
"right2": 0,
"log_extra_report": "",
"log_extra_info": "",
"log_extra_report": "Any components with higher S0 model beta map-F-statistic map Dice similarity index than T2 model beta map-F-statistic map Dice similarity index and greater than median variance explained are rejected.",
"tag_if_true": "Unlikely BOLD"
}
},
"_comment": ""
},
{
"functionname": "calc_median",
"parameters": {
"decide_comps": "all",
"metric_name": "variance explained",
"median_label": "varex"
}
},
"kwargs": {
"log_extra_info": "",
"log_extra_report": "The median variance explained is calculated across all components, for later steps."
},
"_comment": ""
},
tsalo marked this conversation as resolved.
Show resolved Hide resolved
{
"functionname": "dec_left_op_right",
Expand All @@ -90,9 +101,11 @@
"left2": "variance explained",
"op2": ">",
"right2": "median_varex",
"log_extra_report": "",
"log_extra_info": "",
"log_extra_report": "Any components with higher S0 model beta map-F-statistic map Dice similarity index than T2 model beta map-F-statistic map Dice similarity index and greater than median variance explained are rejected.",
"tag_if_true": "Unlikely BOLD"
}
},
"_comment": ""
},
{
"functionname": "dec_left_op_right",
Expand All @@ -108,9 +121,11 @@
"left2": "variance explained",
"op2": ">",
"right2": "median_varex",
"log_extra_report": "",
"log_extra_info": "",
"log_extra_report": "Any components with negative t-statistic comparing distribution of T2* model F-statistics from voxels in clusters to those of voxels not in clusters and variance explained greater than median are rejected.",
"tag_if_true": "Unlikely BOLD"
}
},
"_comment": "This essentially rejects any components with high variance explained and exhibiting more 'speckled' T2*-associated voxels than 'clustered' ones."
},
{
"functionname": "calc_kappa_elbow",
tsalo marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -119,7 +134,7 @@
},
"kwargs": {
"log_extra_info": "",
"log_extra_report": ""
"log_extra_report": "The kappa elbow is calculated from all components, for later steps."
},
"_comment": ""
},
Expand All @@ -132,7 +147,7 @@
"subset_decide_comps": "unclassified",
"rho_elbow_type": "liberal",
"log_extra_info": "",
"log_extra_report": ""
"log_extra_report": "The 'liberal' rho elbow is calculated from all (unclassified?) components, for later steps."
handwerkerd marked this conversation as resolved.
Show resolved Hide resolved
},
"_comment": ""
},
Expand All @@ -147,8 +162,10 @@
"right": "kappa_elbow_kundu"
},
"kwargs": {
"log_extra_report": ""
}
"log_extra_info": "",
"log_extra_report": "Any unclassified components with kappa greater than or equal to the kappa elbow are provisionally accepted. Any remaining unclassified components are provisionally rejected."
},
"_comment": "This step provisionally classifies all 'unclassified' components."
},
{
"functionname": "dec_left_op_right",
Expand All @@ -161,11 +178,12 @@
"right": "rho"
},
"kwargs": {
"log_extra_info": "If kappa>elbow and kappa>2*rho accept even if rho>elbow",
"log_extra_report": "",
"log_extra_info": "",
"log_extra_report": "Any provisionally accepted components with kappa greater than two times rho are accepted.",
"right_scale": 2,
"tag_if_true": "Likely BOLD"
}
},
"_comment": ""
},
{
"functionname": "dec_left_op_right",
Expand All @@ -181,8 +199,10 @@
"right": "rho_elbow_liberal"
},
"kwargs": {
"log_extra_report": ""
}
"log_extra_info": "",
"log_extra_report": "Any provisionally accepted and provisionally rejected components with rho values greater than the liberal rho elbow are provisionally rejected."
},
"_comment": ""
},
{
"functionname": "dec_variance_lessthan_thresholds",
Expand All @@ -194,11 +214,12 @@
"kwargs": {
"var_metric": "variance explained",
"log_extra_info": "",
"log_extra_report": "",
"log_extra_report": "Any provisionally rejected components with variance explained less than ? are accepted.",
tsalo marked this conversation as resolved.
Show resolved Hide resolved
"single_comp_threshold": 0.1,
"all_comp_threshold": 1.0,
"tag_if_true": "Low variance"
}
},
"_comment": ""
},
{
"functionname": "manual_classify",
Expand All @@ -208,9 +229,10 @@
},
"kwargs": {
"log_extra_info": "",
"log_extra_report": "",
"log_extra_report": "All remaining provisionally accepted components are accepted.",
"tag": "Likely BOLD"
}
},
"_comment": ""
},
{
"functionname": "manual_classify",
Expand All @@ -223,9 +245,10 @@
},
"kwargs": {
"log_extra_info": "",
"log_extra_report": "",
"log_extra_report": "All remaining unclassified or provisionally rejected components are rejected.",
"tag": "Unlikely BOLD"
}
},
"_comment": "Are unclassified components even possible at this point?"
}
]
}