Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint codebase with additional style restrictions #970

Merged
merged 37 commits into from
Oct 27, 2023
Merged

Lint codebase with additional style restrictions #970

merged 37 commits into from
Oct 27, 2023

Commits on Aug 12, 2023

  1. Add more flake8 extensions.

    @tsalo
    tsalo committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    92eefa9 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Drop flake8-warnings.

    @tsalo
    tsalo committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    442e4c4 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. Merge branch 'main' into pr/970

    @eurunuela
    eurunuela committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    db9456a View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into pr/970

    @eurunuela
    eurunuela committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    58f4b93 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Merge remote-tracking branch 'upstream/main' into lint-aggressively

    @tsalo
    tsalo committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    3b94a35 View commit details
    Browse the repository at this point in the history

  2. Start addressing issues.

    @tsalo
    tsalo committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    6e14683 View commit details
    Browse the repository at this point in the history

  3. Whoops!

    @tsalo
    tsalo committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    32caae8 View commit details
    Browse the repository at this point in the history

  4. Keep going.

    @tsalo
    tsalo committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8664b05 View commit details
    Browse the repository at this point in the history

  5. More work.

    @tsalo
    tsalo committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    7907c39 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Ran pre-commit in all files

    @eurunuela
    eurunuela committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    7a31872 View commit details
    Browse the repository at this point in the history

  2. Added flynt hook for f strings

    @eurunuela
    eurunuela committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    dab883d View commit details
    Browse the repository at this point in the history

  3. Changed format for f-string in metrics/collect

    @eurunuela
    eurunuela committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    e2788d1 View commit details
    Browse the repository at this point in the history

  4. Fixed all issues in metrics folder

    @eurunuela
    eurunuela committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    e2a6dbe View commit details
    Browse the repository at this point in the history

  5. Fixed metrics unit test

    @eurunuela
    eurunuela committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    6804684 View commit details
    Browse the repository at this point in the history

  6. Undo lowercase from dictionary keys

    @eurunuela
    eurunuela committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    dc2f59d View commit details
    Browse the repository at this point in the history

  7. Lowercase the variable I forgot

    @eurunuela
    eurunuela committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    65e6ef8 View commit details
    Browse the repository at this point in the history

  8. Finished with metrics and io

    @eurunuela
    eurunuela committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    8be1fe6 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Added pydocstringformatter to pre-commit and ran it

    @eurunuela
    eurunuela committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    fd94dae View commit details
    Browse the repository at this point in the history

  2. Changed max number of summary lines to 2

    @eurunuela
    eurunuela committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    0875486 View commit details
    Browse the repository at this point in the history

  3. Added numpy doctstring style to precommit

    @eurunuela
    eurunuela committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    85f57c2 View commit details
    Browse the repository at this point in the history

  4. Update pyproject.toml

    @eurunuela
    eurunuela committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    e3978dc View commit details
    Browse the repository at this point in the history

  5. Removed the numpydoc option because it was driving me crazy

    @eurunuela
    eurunuela committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    885e2cf View commit details
    Browse the repository at this point in the history

  6. Fixed docstrings in bibtex.py

    @eurunuela
    eurunuela committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    eec736f View commit details
    Browse the repository at this point in the history

  7. Did all reporting

    @eurunuela
    eurunuela committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    d4f869c View commit details
    Browse the repository at this point in the history

  8. Fixed workflows

    @eurunuela
    eurunuela committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    0e98d29 View commit details
    Browse the repository at this point in the history

  9. Fixed utils

    @eurunuela
    eurunuela committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    e98cca7 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Fixed a couple of style issue and excluded D from tests

    @eurunuela
    eurunuela committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    42be3df View commit details
    Browse the repository at this point in the history

  2. Did all the selection folder 

    Also updated pydocstringformatter to only allow 1 summary line.
    @eurunuela
    eurunuela committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    7313d5c View commit details
    Browse the repository at this point in the history

  3. Everything except tests should be done by now

    @eurunuela
    eurunuela committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    21551d9 View commit details
    Browse the repository at this point in the history

  4. That should be all!

    @eurunuela
    eurunuela committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    ad924a7 View commit details
    Browse the repository at this point in the history

  5. Fixed error

    @eurunuela
    eurunuela committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    ab279f9 View commit details
    Browse the repository at this point in the history

  6. Update link to black pre-commit repo

    @eurunuela
    eurunuela committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    0d8730f View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Fix LaTeX equation errors in PCA decomposition docstring

    @eurunuela
    eurunuela committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    897c674 View commit details
    Browse the repository at this point in the history

  2. Use r and single slash

    @eurunuela
    eurunuela committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    e194bac View commit details
    Browse the repository at this point in the history

  3. Fix double slash in combine

    @eurunuela
    eurunuela committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    0e5db8e View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Delete _utils.py

    @eurunuela
    eurunuela committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    a126ffa View commit details
    Browse the repository at this point in the history

  2. Update tedana/reporting/static_figures.py 

    Co-authored-by: Dan Handwerker <7406227+handwerkerd@users.noreply.github.com>
    @eurunuela @handwerkerd
    eurunuela and handwerkerd committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    964b0f6 View commit details
    Browse the repository at this point in the history