Skip to content

Commit

Permalink
Minor sign efficiency upgrades
Browse files Browse the repository at this point in the history
  • Loading branch information
@ME1312
ME1312 committed Mar 18, 2022
1 parent a4d9f46 commit b7c89d2
Show file tree
Hide file tree
Showing 3 changed files with 51 additions and 83 deletions.
128 changes: 48 additions & 80 deletions SubServers.Client/Bukkit/src/net/ME1312/SubServers/Client/Bukkit/SubSigns.java
View file
Expand Up @@ -23,7 +23,6 @@
import org.bukkit.event.block.BlockBreakEvent;
import org.bukkit.event.block.SignChangeEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.event.world.WorldLoadEvent;

import java.io.*;
import java.nio.ByteBuffer;
Expand Down Expand Up @@ -118,29 +117,6 @@ private void load() throws IOException {
}
}

@EventHandler(priority = EventPriority.MONITOR)
public void load(WorldLoadEvent e) {
UUID wid = e.getWorld().getUID();
ArrayList<OfflineBlock> removals = new ArrayList<OfflineBlock>();
HashMap<Location, String> signs = new HashMap<Location, String>(SubSigns.signs);
for (Entry<OfflineBlock, String> sign : data.entrySet()) {
if (wid == sign.getKey().world) {
OfflineBlock location = sign.getKey();
Location loaded = location.load();
if (loaded.getBlock().getState() instanceof Sign) {
signs.put(loaded, sign.getValue());
} else {
removals.add(sign.getKey());
Bukkit.getLogger().warning("SubServers > Removed invalid sign data: [\"" + loaded.getWorld().getName() + "\", " + location.x + ", " + location.y + ", " + location.z + "] -> \"" + sign.getValue() + '\"');
}
}
}
SubSigns.signs = signs;
for (OfflineBlock location : removals) {
data.remove(location);
}
}

@EventHandler(priority = EventPriority.MONITOR)
public void create(SignChangeEvent e) {
if (!e.isCancelled() && plugin.lang != null && e.getLine(0).trim().equalsIgnoreCase("[SubServers]")) {
Expand All @@ -162,17 +138,6 @@ public void create(SignChangeEvent e) {
}
}
}

private Object translate(String name) {
if (name.startsWith("::")) {
return plugin.phi.cache.getHost(name.substring(2));
} else if (name.startsWith(":")) {
return plugin.phi.cache.getGroup(name.substring(1));
} else {
return plugin.phi.cache.getServer(name);
}
}

private void listen() {
if (!active && !signs.isEmpty()) {
active = true;
Expand All @@ -191,18 +156,19 @@ private void refresh() {

private void refresh(SubServer server) {
if (server != null && plugin.lang != null) {
String name;
List<String> groups = server.getGroups();
String[] names = new String[groups.size() + 2];
names[0] = server.getName();
int i = 0; for (String group : groups) names[++i] = ':' + group;
names[++i] = "::" + server.getHost();

String object;
for (Entry<Location, String> pos : signs.entrySet()) {
if ((name = pos.getValue()).equalsIgnoreCase(server.getName())) {
refresh(pos.getKey().getBlock(), server);
} else if (name.equalsIgnoreCase("::" + server.getHost())) {
refresh(pos.getKey().getBlock(), plugin.phi.cache.getHost(server.getHost()));
} else {
for (String group : server.getGroups()) {
if (name.equalsIgnoreCase(':' + group)) {
refresh(pos.getKey().getBlock(), plugin.phi.cache.getGroup(group));
break;
}
object = pos.getValue();
for (String name : names) {
if (name.equalsIgnoreCase(object)) {
refresh(pos.getKey().getBlock(), object);
break;
}
}
}
Expand Down Expand Up @@ -246,50 +212,45 @@ private static Text determine(Server server) {
}
}

@SuppressWarnings("unchecked")
private void refresh(Block block, Object object) {
private void refresh(Block block, String name) {
if (block.getState() instanceof Sign) {
Sign sign = (Sign) block.getState();
Text state = Text.UNKNOWN;
String name = "null";
int players = 0;

// re-define the object
if (object instanceof String) {
object = translate(name = (String) object);
}
if (name.startsWith("::") && name.length() > 2) {
Host host = plugin.phi.cache.getHost(name.substring(2));
if (host == null) return;

// read the object
if (object instanceof Host) {
Host host = (Host) object;
name = host.getDisplayName();

Text incoming;
for (SubServer server : ((Host) object).getSubServers().values()) {
for (SubServer server : host.getSubServers().values()) {
players += server.getRemotePlayers().size();
incoming = Text.determine(server);
if (incoming.priority > state.priority)
state = incoming;
}
} else if (object instanceof Pair) {
Pair<String, List<Server>> group = (Pair<String, List<Server>>) object;
name = group.key();
} else if (name.startsWith(":") && name.length() > 1) {
Pair<String, List<Server>> group = plugin.phi.cache.getGroup(name.substring(1));
if (group == null) return;

name = group.key();
Text incoming;
for (Server server : group.value()) {
players += server.getRemotePlayers().size();
incoming = Text.determine(server);
if (incoming.priority > state.priority)
state = incoming;
}
} else if (object instanceof Server) {
Server server = (Server) object;
} else {
Server server = plugin.phi.cache.getServer(name);
if (server == null) return;

state = Text.determine(server);
name = server.getDisplayName();
players = server.getRemotePlayers().size();
}

// update the sign
String[] text = plugin.phi.replace(null, plugin.api.getLang("SubServers", state.text).replace("$str$", name).replace("$int$", NumberFormat.getInstance().format(players))).split("\n", 4);
for (int i = 0; i < 4; ++i) if (i < text.length) {
sign.setLine(i, text[i]);
Expand All @@ -306,34 +267,41 @@ public void interact(PlayerInteractEvent e) {
if (!e.isCancelled() && e.getClickedBlock() != null && plugin.lang != null && plugin.api.getSubDataNetwork()[0] != null && !plugin.api.getSubDataNetwork()[0].isClosed() && signs.containsKey(e.getClickedBlock().getLocation())) {
Player player = e.getPlayer();
if ((e.getAction() == Action.RIGHT_CLICK_BLOCK || !player.hasPermission("subservers.signs")) && player.hasPermission("subservers.teleport")) {
Object object = translate(signs.get(e.getClickedBlock().getLocation()));
String name = signs.get(e.getClickedBlock().getLocation());

Collection<? extends Server> servers;
if (object instanceof Host) {
servers = ((Host) object).getSubServers().values();
} else if (object instanceof Pair) {
servers = ((Pair<String, List<Server>>) object).value();
} else if (object instanceof Server) {
servers = Collections.singleton((Server) object);
if (name.startsWith("::") && name.length() > 2) {
Host host = plugin.phi.cache.getHost(name.substring(2));
if (host == null) return;
servers = host.getSubServers().values();
} else if (name.startsWith(":") && name.length() > 1) {
Pair<String, List<Server>> group = plugin.phi.cache.getGroup(name.substring(1));
if (group == null) return;
servers = group.value();
} else {
return;
Server server = plugin.phi.cache.getServer(name);
if (server == null) return;
servers = Collections.singleton(server);
}

Text incoming, state = Text.UNKNOWN;
List<Server> selected = new ArrayList<>();
for (Server server : servers) {
incoming = Text.determine(server);
if (incoming.priority > state.priority) {
selected.clear();
state = incoming;
}

if (incoming == state) {
if (state == Text.OFFLINE) {
if (incoming != Text.STOPPING) {
if (incoming == Text.OFFLINE) {
SubServer subserver = (SubServer) server;
if (!(subserver.isEnabled() && subserver.isAvailable() && subserver.getCurrentIncompatibilities().size() == 0)) continue;
}
selected.add(server);

if (incoming.priority > state.priority) {
selected.clear();
state = incoming;
}

if (incoming == state) {
selected.add(server);
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion SubServers.Client/Common/src/net/ME1312/SubServers/Client/Common/Network/API/Server.java
View file
Expand Up @@ -118,7 +118,7 @@ public InetSocketAddress getAddress() {
* @return Group names
*/
public List<String> getGroups() {
return new LinkedList<String>(raw.getStringList("group"));
return raw.getStringList("group");
}

/**
Expand Down
4 changes: 2 additions & 2 deletions SubServers.Client/Common/src/net/ME1312/SubServers/Client/Common/Network/API/SubServer.java
View file
Expand Up @@ -627,7 +627,7 @@ public boolean isCompatible(String server) {
* @return Incompatibility List
*/
public List<String> getIncompatibilities() {
return new LinkedList<String>(raw.getStringList("incompatible-list"));
return raw.getStringList("incompatible-list");
}

/**
Expand Down Expand Up @@ -671,7 +671,7 @@ public void getIncompatibilities(Consumer<List<SubServer>> callback) {
* @return Current Incompatibility List
*/
public List<String> getCurrentIncompatibilities() {
return new LinkedList<String>(raw.getStringList("incompatible"));
return raw.getStringList("incompatible");
}

/**
Expand Down

0 comments on commit b7c89d2

Please sign in to comment.