Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vertical flip bit not working on HW and adding feature -ve y_offset #799

Merged
merged 1 commit into from Apr 29, 2024

Conversation

RetroCogs
Copy link
Contributor

This is to address issue #796

This is using bit 4 of screen ram byte 1 when GOTOX is set to specify that the y_offset should be subtracted from the glyph_data_address.

This also fixes the issue that when vertical flip bit was set, y_offset would be ignored.

Tested FirstShot, all RetroCogs tutorials, Unicone, Showdown, IntroDisk #1 RRB Demo, Xanadu demo

Copy link
Member

@lydon42 lydon42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Is there some piece of testcode that could be used for automated testing?
So a RRB char that is Y offset in plus and then in minus direction, each time pixels are read with the debug crosshairs to see if the change was as expected.

@RetroCogs
Copy link
Contributor Author

So yes, when nve_offset bit is set the offset is subracted rather than the default of added.

This also fixes the fact that when vertical flip bit was set it would ignore the y_offset.

I'm happy to add some tests similar to test_671.c as a separate pull request into mega65_tools.

@lydon42 lydon42 merged commit 9b0066c into MEGA65:development Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants