Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit for Review from the Preview Page #2078

Closed
gmeben opened this issue Mar 11, 2024 · 1 comment · Fixed by #2118 · May be fixed by #2116
Closed

Submit for Review from the Preview Page #2078

gmeben opened this issue Mar 11, 2024 · 1 comment · Fixed by #2118 · May be fixed by #2116
Assignees
@gmeben
Labels
💍 feature New feature or request 🖥️ frontend Related to the Vue/JS portions

Comments

@gmeben
Copy link
Contributor

gmeben commented Mar 11, 2024

When viewing a submission that is not in a reviewable state, the header that typically contains the component to change the submission's status so that it can be submitted for review does not appear. This component also controls changing the status of a submission to other statuses. This means a user has to inconveniently go elsewhere to change the status of a submission.

Make the status change component appear on the Preview page.

Review Checklist

  • The component appears on the Preview page
  • The submission can be submitted for review from the Preview page
  • Necessary integration testing has been added

Accessibility Checklist

  • No new color contrast issues are introduced
  • Changed text has a font size of at least 16px
  • Changed text uses plain language
@gmeben gmeben added 💍 feature New feature or request 🖥️ frontend Related to the Vue/JS portions labels Mar 11, 2024
@gmeben gmeben changed the title Submit for Review on the Preview Page Submit for Review from the Preview Page Mar 11, 2024
@sattler9
Copy link
Contributor

Hey team! Please add your planning poker estimate with Zenhub @gmeben @vilagshe @wreality

@gmeben gmeben self-assigned this May 13, 2024
@gmeben gmeben mentioned this issue May 21, 2024
Merged
gmeben added a commit that referenced this issue May 30, 2024
@gmeben
feat: Submit Submission from Preview Page (#2118)
330f7ae 
* Refactors status changing template logic to a new component `StatusChangeDropdown`
    * uses data-driven logic for improved reusability
* Simplifies submission acceptance process
    * Accepting for review is no longer necessary; only opening for review
* Adds the `StatusChangeDropdown` component to the preview, view, and review pages
* Adds a check for status changes to draft and initially submitted submissions so that the interface changes accordingly
    * Draft submissions are redirected from the preview page to the view page
    * Initially Submitted submissions are redirected from the view page to the review page
* Bonus: Adds scope attributes to `i18n` tags to prevent warnings about global scope

Closes #2078
@wreality wreality mentioned this issue May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmeben gmeben

Labels
💍 feature New feature or request 🖥️ frontend Related to the Vue/JS portions
Projects
None yet
Milestone
No milestone
2 participants
@gmeben @sattler9