drop python 3.8 support (#371)

* drop py3.8 support

* code updates

* black with target-version

* changelog

* isort

.github/workflows/ci-cd-workflow.yml

@@ -60,7 +60,7 @@ jobs:
     strategy:
       matrix:
         os: ["ubuntu-latest"]
-        python-version: ["3.8", "3.9", "3.11"]
+        python-version: ["3.9", "3.11"]
     defaults:
       run:
         shell: bash -l {0}

CHANGELOG.rst

@@ -16,7 +16,11 @@ By `Mathias Hauser`_.
 Breaking changes
 ^^^^^^^^^^^^^^^^
 
-- Removed support for Python 3.7 (`#163 <https://github.com/MESMER-group/mesmer/issues/163>`_.).
+- Removed support for python 3.7 and python 3.8 and updated the code base (
+  `#163 <https://github.com/MESMER-group/mesmer/issues/163>`_,
+  `#365 <https://github.com/MESMER-group/mesmer/pull/365>`_,
+  `#367 <https://github.com/MESMER-group/mesmer/pull/367>`_, and
+  `#371 <https://github.com/MESMER-group/mesmer/pull/371>`_).
   By `Mathias Hauser`_.
 
 v0.9.0 - 2023.12.19

docs/source/installation.rst

@@ -4,7 +4,7 @@ Installation
 Required dependencies
 ---------------------
 
-- Python (3.8 or later)
+- Python (3.9 or later)
 - `dask <https://dask.org/>`__
 - `numpy <http://www.numpy.org/>`__
 - `pandas <https://pandas.pydata.org/>`__

mesmer/core/grid.py

@@ -82,7 +82,7 @@ def stack_lat_lon(
     y_dim="lat",
     stack_dim="gridcell",
     multiindex=False,
-    dropna=True
+    dropna=True,
 ):
     """Stack a regular lat-lon grid to a 1D (unstructured) grid
 

mesmer/core/utils.py

@@ -1,5 +1,5 @@
 import warnings
-from typing import Set, Union
+from typing import Union
 
 import numpy as np
 import xarray as xr
@@ -106,8 +106,8 @@ def _check_dataset_form(
     obj,
     name: str = "obj",
     *,
-    required_vars: Union[str, Set[str]] = set(),
-    optional_vars: Union[str, Set[str]] = set(),
+    required_vars: Union[str, set[str]] = set(),
+    optional_vars: Union[str, set[str]] = set(),
     requires_other_vars: bool = False,
 ):
     """check if a dataset conforms to some conditions
@@ -156,7 +156,7 @@ def _check_dataarray_form(
     name: str = "obj",
     *,
     ndim: int = None,
-    required_dims: Union[str, Set[str]] = set(),
+    required_dims: Union[str, set[str]] = set(),
     shape=None,
 ):
     """check if a dataset conforms to some conditions

mesmer/stats/_linear_regression.py

@@ -1,4 +1,5 @@
-from typing import Mapping, Optional
+from collections.abc import Mapping
+from typing import Optional
 
 import numpy as np
 import xarray as xr

setup.cfg

@@ -19,7 +19,6 @@ classifiers =
     Intended Audience :: Science/Research
     Programming Language :: Python
     Programming Language :: Python :: 3
-    Programming Language :: Python :: 3.8
     Programming Language :: Python :: 3.9
     Programming Language :: Python :: 3.10
     Programming Language :: Python :: 3.11
@@ -30,7 +29,7 @@ classifiers =
 packages = find:
 zip_safe = False  # https://mypy.readthedocs.io/en/latest/installed_packages.html
 include_package_data = True
-python_requires = >=3.8
+python_requires = >=3.9
 install_requires =
     dask[complete]
     numpy

tests/unit/test_grid.py

@@ -231,6 +231,6 @@ def test_unstructured_roundtrip_2D_coords(as_dataset):
 
     result = mesmer.grid.stack_lat_lon(
         mesmer.grid.unstack_lat_lon_and_align(da_unstructured, coords_orig, **dims),
-        **dims
+        **dims,
     )
     xr.testing.assert_identical(result, da_unstructured)