Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore compatibility with regionmask v0.9.0 #136

Merged
merged 4 commits into from Mar 18, 2022

Conversation

mathause
Copy link
Member

@mathause
Copy link
Member Author

I don't get what is wrong here - almost looks like the code change is not picked up? I am confused.

@mathause
Copy link
Member Author

And why is only one CI finishing?

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #136 (ae63399) into master (459421d) will decrease coverage by 0.14%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   79.12%   78.97%   -0.15%     
==========================================
  Files          29       29              
  Lines        1341     1346       +5     
==========================================
+ Hits         1061     1063       +2     
- Misses        280      283       +3     
Flag Coverage Δ
unittests 78.97% <55.55%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mesmer/io/load_constant_files.py 93.10% <55.55%> (-3.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 459421d...ae63399. Read the comment docs.

@mathause mathause merged commit a682256 into MESMER-group:master Mar 18, 2022
@mathause mathause deleted the restore_regionmask_compat branch March 18, 2022 14:08
@mathause
Copy link
Member Author

Ok, found it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants