Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quantile: rename interpolation kwarg to method #137

Merged

Conversation

mathause
Copy link
Member

numpy v1.22.0 introduces some changes to np.quantile it renames the interpolation keyword to method. This PR restores compatibility with numpy 1.22.

  • Passes isort . && black . && flake8
  • Fully documented, including CHANGELOG.rst

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #137 (13562fe) into master (a682256) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   78.97%   79.05%   +0.07%     
==========================================
  Files          29       29              
  Lines        1346     1351       +5     
==========================================
+ Hits         1063     1068       +5     
  Misses        283      283              
Flag Coverage Δ
unittests 79.05% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mesmer/calibrate_mesmer/train_gv.py 85.33% <100.00%> (+0.40%) ⬆️
mesmer/create_emulations/create_emus_gv.py 73.46% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a682256...13562fe. Read the comment docs.

@mathause mathause merged commit b50abbe into MESMER-group:master Mar 18, 2022
@mathause mathause deleted the quantile_interpolation_method branch March 18, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants