New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test, refactor, and deprecate extract_time_period #243

Merged

mathause merged 3 commits into MESMER-group:main from mathause:test_refactor_deprecate_extract_time_period

Jan 18, 2023

Member

mathause commented Jan 18, 2023 •

edited

Closes #xxx
Tests added
Passes isort . && black . && flake8
Fully documented, including CHANGELOG.rst

I wanted to refactor extract_time_period so I wrote some tests and then I realized that this function is not used internally, so I deprecated it...

mathause added 3 commits

January 18, 2023 18:31


          test, refactor, and deprecate extract_time_period

ee1bc5c


          changlog

99041ea


          update deprecation warning

0cdb9d9

mathause merged commit 886278d into MESMER-group:main

mathause deleted the test_refactor_deprecate_extract_time_period branch

January 18, 2023 21:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment