Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowess: allow missing input_core_dim #283

Merged

Conversation

mathause
Copy link
Member

@mathause mathause commented Sep 5, 2023

  • Closes #xxx
  • Tests added
  • Passes isort . && black . && flake8
  • Fully documented, including CHANGELOG.rst

Allow missing core dims in mesmer.stats.lowess. This will help to pass arbitrary Datasets.

mesmer/stats/smoothing.py Outdated Show resolved Hide resolved
tests/unit/test_smoothing.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (e38fef0) 86.33% compared to head (694c5f2) 86.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   86.33%   86.39%   +0.05%     
==========================================
  Files          38       38              
  Lines        1537     1543       +6     
==========================================
+ Hits         1327     1333       +6     
  Misses        210      210              
Flag Coverage Δ
unittests 86.39% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
mesmer/stats/smoothing.py 95.23% <100.00%> (+1.90%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathause mathause merged commit 2cc49a2 into MESMER-group:main Sep 5, 2023
6 of 7 checks passed
@mathause mathause deleted the lowess_allow_missing_input_core_dim branch September 5, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant