Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mask_ocean for 2D grids #314

Merged
merged 3 commits into from Sep 29, 2023
Merged

Conversation

mathause
Copy link
Member

  • Closes #xxx
  • Tests added
  • Passes isort . && black . && flake8
  • Fully documented, including CHANGELOG.rst

We are working with the coords so we need to check that the coords are in the DataArray and not the dims.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (91b184b) 87.16% compared to head (7bfa6e7) 87.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #314   +/-   ##
=======================================
  Coverage   87.16%   87.16%           
=======================================
  Files          38       38           
  Lines        1621     1621           
=======================================
  Hits         1413     1413           
  Misses        208      208           
Flag Coverage Δ
unittests 87.16% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
mesmer/core/mask.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathause mathause merged commit b30b6b1 into MESMER-group:main Sep 29, 2023
7 checks passed
@mathause mathause deleted the mask_ocean_2D_grid branch September 29, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant