Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure un-sorted hist de-duplication #339

Merged
merged 7 commits into from Dec 19, 2023

Conversation

mathause
Copy link
Member

@mathause mathause commented Nov 19, 2023

This should make the hist ensemble members unique without shuffling them. The test files are not yet updated. I am also not sure if I will merge this into v0.9, or wait for afterwards.


edit: I decided to create a new version v0.9.1 for this. I don't close the related issue because I want to at estimate the implication of this first.

@mathause mathause marked this pull request as ready for review December 19, 2023 23:27
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (616c8f2) 87.88% compared to head (14c0619) 87.95%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   87.88%   87.95%   +0.06%     
==========================================
  Files          40       40              
  Lines        1742     1752      +10     
==========================================
+ Hits         1531     1541      +10     
  Misses        211      211              
Flag Coverage Δ
unittests 87.95% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathause mathause merged commit 6f5d3e5 into MESMER-group:main Dec 19, 2023
7 checks passed
@mathause mathause deleted the sorted_unique_hist branch December 19, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant