Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade code to pyhon 3.8 and xarray 2022.03 #367

Merged
merged 1 commit into from Jan 3, 2024

Conversation

mathause
Copy link
Member

@mathause mathause commented Jan 3, 2024

Moving to python 3.8+ allows some simplifications. Also the lowest xarray version supporting py3.8 is v2022.03.0 which allows further code clean ups. Could have done this in #365...

  • Closes #xxx
  • Tests added
  • Passes isort . && black . && flake8
  • Fully documented, including CHANGELOG.rst

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e30aa89) 87.72% compared to head (bab94ea) 87.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   87.72%   87.90%   +0.17%     
==========================================
  Files          40       40              
  Lines        1752     1744       -8     
==========================================
- Hits         1537     1533       -4     
+ Misses        215      211       -4     
Flag Coverage Δ
unittests 87.90% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathause mathause merged commit af83255 into MESMER-group:main Jan 3, 2024
7 checks passed
@mathause mathause deleted the py38_upgrades branch January 3, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant