remove jac=rosen_der for from power transformer optimization #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
==========================================
- Coverage 87.90% 83.66% -4.25%
==========================================
Files 40 43 +3
Lines 1745 1928 +183
==========================================
+ Hits 1534 1613 +79
- Misses 211 315 +104
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mathause
approved these changes
May 16, 2024
veni-vidi-vici-dormivi
added a commit
to veni-vidi-vici-dormivi/mesmer
that referenced
this pull request
May 23, 2024
…group#447) * remove rosender for pt jacobian * remove rosender import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using rosen_der for the Jacobian in the power transformer optimization lead to instabilities in the fit, see discussion in #440