-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTD: remove transitive deps from docs env #449
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
==========================================
- Coverage 87.90% 83.73% -4.18%
==========================================
Files 40 44 +4
Lines 1745 1949 +204
==========================================
+ Hits 1534 1632 +98
- Misses 211 317 +106
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ah another one.
Would that remove the need for the docs to have its own yml? |
Potentially - we could use the (As long as we don't need any non-python dependency [which was the ultimate problem in regionmask/regionmask#450]) |
I suggest to merge this and try the pip installation in another PR (see #453) |
- statsmodels | ||
- regionmask>=0.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we remove the version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something less to keep track of. It should per default install the newest versions. (But yes there are also arguments for keeping it - so no real good reason).
* RTD: remove transitive deps from docs env * add comment
This adds all of our direct dependencies to the docs environment (following #448) but removes the transitive ones. The direct ones were installed before, just not explicitly listed. Unfortunately sphinx (or maybe just the autosummary extension) imports the functions it wants to create the docs for, so they must be installed. However, leaving the optional transitive deps away should lead to a small speed up.
Alternatively we could install everything using pip but that would be more work (c.f. regionmask/regionmask#450)