Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor load_cmipng_tas and load_cmipng_hfds #55

Merged
merged 16 commits into from Oct 27, 2021

Conversation

mathause
Copy link
Member

This adds a common function for load_cmipng_tas and load_cmipng_hfds as suggested by your comment. The only difference was the use of np.average with a masked vs not-masked array. As tas has data everywhere this should not make a difference.

Next up are then tests and then an internal refactor.

@mathause
Copy link
Member Author

I might still want to add tests here (after #52)

This was referenced Aug 24, 2021
tests/test_load_cmipng.py Outdated Show resolved Hide resolved
mesmer/io/_load_cmipng.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #55 (61305b3) into master (d73e8f5) will increase coverage by 0.81%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   77.53%   78.34%   +0.81%     
==========================================
  Files          26       26              
  Lines        1322     1293      -29     
==========================================
- Hits         1025     1013      -12     
+ Misses        297      280      -17     
Flag Coverage Δ
unittests 78.34% <89.47%> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mesmer/io/_load_cmipng.py 79.36% <88.88%> (ø)
mesmer/io/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d73e8f5...61305b3. Read the comment docs.

@mathause
Copy link
Member Author

This would be ready for review. More refactoring could be done but let's do this in another PR.

@mathause mathause merged commit f70274b into master Oct 27, 2021
@mathause mathause deleted the refactor_load_cmipng_tas_hfds branch October 27, 2021 17:03
mathause added a commit to mathause/mesmer that referenced this pull request Dec 17, 2021
mathause added a commit that referenced this pull request Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants