Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example script #80

Merged
merged 4 commits into from Jul 15, 2021
Merged

Update example script #80

merged 4 commits into from Jul 15, 2021

Conversation

leabeusch
Copy link
Collaborator

No description provided.

@leabeusch leabeusch requested a review from mathause July 13, 2021 08:15
Copy link
Member

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But I haven't tested it.

Change directory so actually works, delete an unnecessary variable, fix
a comment
Include derivation of full global variability emulations and limit the
number of trialled localisation radii to a smaller number since larger
number of no added value with our incredibly coarse test data.
@leabeusch
Copy link
Collaborator Author

leabeusch commented Jul 14, 2021

I actually tested it now and noticed that we had still an old pathway to the test data in the config file -> I update this one plus added full global emulation creation in the example script to also highlight this MESMER feature + I made a few other minor changes. Whether the output is reasonable, I didn't check. But I think this is fine for now, especially since we intend to create actually nice examples in the near(ish)-term future.

@leabeusch leabeusch merged commit 9fee132 into master Jul 15, 2021
@leabeusch leabeusch deleted the update_example branch July 15, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants