Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upcoming features #15

Merged
merged 5 commits into from Feb 22, 2024
Merged

Feature/upcoming features #15

merged 5 commits into from Feb 22, 2024

Conversation

roanutil
Copy link
Member

  • Enable all upcoming swift features
  • Fix build errors for missing any on existential
  • Add Hashable and Sendable conformances to HTTPMethod and ContentType
  • Run swiftformat

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (16abd6d) 72.50% compared to head (d33158d) 72.67%.

Files Patch % Lines
Sources/NetworkService/Result+NetworkService.swift 66.66% 1 Missing ⚠️
Sources/NetworkService/URLRequest+HTTPHeader.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   72.50%   72.67%   +0.16%     
==========================================
  Files          27       27              
  Lines         662      666       +4     
==========================================
+ Hits          480      484       +4     
  Misses        182      182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-jarvis r-jarvis merged commit 546d9b3 into main Feb 22, 2024
6 checks passed
@roanutil roanutil deleted the feature/upcoming-features branch February 22, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants