Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

Lag when loading a large list of tv shows #138

Closed
6cUbi57z opened this issue Jun 20, 2017 · 2 comments
Closed

Lag when loading a large list of tv shows #138

6cUbi57z opened this issue Jun 20, 2017 · 2 comments
Labels
Projects
Milestone

Comments

@6cUbi57z
Copy link

Bug report

  • ShowsRage version: v2017.03.31-1
  • Android version: 6.0.1
  • Device: Samsung Galaxy Tab A6

Issue description

I am experiencing lag when first opening the app and sometimes when scrolling through the TV list.

I have some experience with Android development (although have not looked through the code) and I believe the issue is caused by the list item renderer. When the app first opens, the list items are very small as they do not yet have a banner image and so lots of the items are displayed on the screen. This causes the app to request the banner image for every visible item in the show list which causes the lag.

Expected result

If the list item view were to have a fixed height or a placeholder image while the banner loads, there would not be as many list items initially visible in the list and not as many request would be made. This should reduce the lag (not to mention that the placeholder would be asthetically pleasing :) )

Steps to reproduce

  1. Configure a sickrage instance with a large number of shows (e.g. 100). A slower machine may be best (i.e. a raspberry pi).
  2. From a tablet or large screen/high dpi device, connect showrage to the sickrage instance
  3. When the show list is loading, perform some UI interaction (i.e. opening the menu drawer, scrolling)
  4. Bonus: Scrolling the TV list fast can sometimes also lag
@MGaetan89 MGaetan89 added the Bug label Jun 20, 2017
@MGaetan89 MGaetan89 added this to the 1.6 milestone Jun 20, 2017
@MGaetan89 MGaetan89 added this to Todo in 1.6 Jun 20, 2017
@MGaetan89
Copy link
Owner

Thanks for the detailed report.
I also noticed this issue when using the poster layout. Your solution will definitely help improve the start time.
From my investigation, the loading of the show stats also slows down the display of the list of shows.
I will improve this point in the next version of ShowsRage.

@MGaetan89
Copy link
Owner

I have implemented this.
It will be part of the next version (1.6).

@MGaetan89 MGaetan89 moved this from Todo to In progress in 1.6 May 17, 2018
@MGaetan89 MGaetan89 moved this from In progress to Done in 1.6 May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
1.6
Done
Development

No branches or pull requests

2 participants