Bugfix: Solved N+1 problem in User isDeletable()

MGeurts · May 25, 2024 · 19e1f93 · 19e1f93
1 parent 7368e3a
commit 19e1f93
Show file tree

Hide file tree

Showing 3 changed files with 230 additions and 36 deletions.
diff --git a/app/Models/Team.php b/app/Models/Team.php
@@ -52,7 +52,7 @@ protected function casts(): array
     /* -------------------------------------------------------------------------------------------- */
     public function isDeletable(): bool
     {
-        return count($this->persons) == 0 and count($this->couples) == 0 and count($this->users) == 0;
+        return $this->persons->count() == 0 and $this->couples->count() and $this->users->count() == 0;
     }
 
     /* -------------------------------------------------------------------------------------------- */

diff --git a/app/Models/User.php b/app/Models/User.php
@@ -119,13 +119,15 @@ public function teamsStatistics()
 
     public function isDeletable(): bool
     {
-        foreach ($this->ownedTeams as $team) {
-            if (! $team->isDeletable()) {
-                return false;
-            }
-        }
+        $count = DB::select('
+            SELECT 
+                SUM((SELECT COUNT(*) FROM `users` INNER JOIN `team_user` ON `users`.`id` = `team_user`.`user_id` WHERE `teams`.`id` = `team_user`.`team_id` AND `users`.`deleted_at` IS NULL)) +
+                SUM((SELECT COUNT(*) FROM `people` WHERE `teams`.`id` = `people`.`team_id` AND `people`.`deleted_at` IS NULL)) +
+                SUM((SELECT COUNT(*) FROM `couples` WHERE `teams`.`id` = `couples`.`team_id`)) AS `items_count` 
+            FROM `teams` WHERE `user_id` = ' . $this->id . ';
+        ');
 
-        return true;
+        return (int) reset($count[0]) == 0;
     }
 
     /* -------------------------------------------------------------------------------------------- */