Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional parameter frequency_dimension across wave.resource #336

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Add optional parameter frequency_dimension across wave.resource #336

wants to merge 5 commits into from

Conversation

akeeste
Copy link
Contributor

@akeeste akeeste commented Jun 27, 2024 •
edited
Loading

This PR makes the xarray work in wave.resource more consistent by adding the optional parameter frequency_dimension to functions like significant_wave_height that then pass the parameter to frequency_moment.

This is an immediate speed fix for #331 by allowing xarray formats to be passed to all relevant wave.resource functions

@ssolson
Copy link
Contributor

ssolson commented Jun 27, 2024

@akeeste in case you are catching up we need to get #335 merged before anything will pass tests due to the numpy 2.0.0 upgrade. (waiting on the wind hindcast rn which is everyone's favorite 5 hour test).

@akeeste akeeste mentioned this pull request Jun 28, 2024
Open
@akeeste akeeste requested a review from ssolson July 16, 2024 20:02
@akeeste akeeste mentioned this pull request Jul 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssolson ssolson Awaiting requested review from ssolson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akeeste @ssolson