Skip to content

Commit

Permalink
IP Limit Tweaks to reduce false bans (#850)
Browse files Browse the repository at this point in the history
* IP Limit Tweaks to reduce false bans
1) Check IPs every 10s instead of 20s
2) F2B jail: maxretry 3 -> 4, findtime 100 -> 60

* USERS SHOULD UPDATE BANTIME ONCE AFTER UPDATE
to recreate jail for Ip Limit
  • Loading branch information
somebodywashere committed Aug 1, 2023
1 parent b805bf6 commit dd0217b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions web/job/check_client_ip_job.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ func (j *CheckClientIpJob) processLogFile() {

}

// added 3 seconds delay before cleaning logs to reduce chance of logging IP that already has been banned
time.Sleep(time.Second * 3)
// added delay before cleaning logs to reduce chance of logging IP that already has been banned
time.Sleep(time.Second * 2)

if shouldCleanLog {
// copy access log to persistent file
Expand Down
4 changes: 2 additions & 2 deletions web/web.go
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,8 @@ func (s *Server) startTask() {
// Check the inbound traffic every 30 seconds that the traffic exceeds and expires
s.cron.AddJob("@every 30s", job.NewCheckInboundJob())

// check client ips from log file every 20 sec
s.cron.AddJob("@every 20s", job.NewCheckClientIpJob())
// check client ips from log file every 10 sec
s.cron.AddJob("@every 10s", job.NewCheckClientIpJob())

// check client ips from log file every 3 day
s.cron.AddJob("@every 3d", job.NewClearLogsJob())
Expand Down
4 changes: 2 additions & 2 deletions x-ui.sh
Original file line number Diff line number Diff line change
Expand Up @@ -713,8 +713,8 @@ enabled=true
filter=3x-ipl
action=3x-ipl
logpath=${iplimit_log_path}
maxretry=3
findtime=100
maxretry=4
findtime=60
bantime=${bantime}m
EOF

Expand Down

0 comments on commit dd0217b

Please sign in to comment.