remove favicon from web root

Co-Authored-By: Alireza Ahmadi <alireza7@gmail.com>
MHSanaei · Apr 28, 2023 · ee89666 · ee89666
1 parent 177bd03
commit ee89666
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/web/html/common/head.html b/web/html/common/head.html
@@ -7,7 +7,8 @@
     <link rel="stylesheet" href="{{ .base_path }}assets/ant-design-vue@1.7.2/antd.min.css">
     <link rel="stylesheet" href="{{ .base_path }}assets/element-ui@2.15.0/theme-chalk/display.css">
     <link rel="stylesheet" href="{{ .base_path }}assets/css/custom.css?{{ .cur_ver }}">
-    <link rel="shortcut icon" href="/favicon.ico" type="image/x-icon">
+    <link rel=”icon” type=”image/x-icon” href="{{ .base_path }}assets/favicon.ico">
+    <link rel="shortcut icon" type="image/x-icon" href="{{ .base_path }}assets/favicon.ico">
     <style>
         [v-cloak] {
             display: none;

diff --git a/web/web.go b/web/web.go
@@ -33,9 +33,6 @@ import (
 //go:embed assets/*
 var assetsFS embed.FS
 
-//go:embed assets/favicon.ico
-var favicon []byte
-
 //go:embed html/*
 var htmlFS embed.FS
 
@@ -161,11 +158,6 @@ func (s *Server) initRouter() (*gin.Engine, error) {
 
 	engine := gin.Default()
 
-	// Add favicon
-	engine.GET("/favicon.ico", func(c *gin.Context) {
-		c.Data(200, "image/x-icon", favicon)
-	})
-
 	secret, err := s.settingService.GetSecret()
 	if err != nil {
 		return nil, err