nusamai-gpkg: クレートの作成、空のGeoPackageファイル作成 #89
Merged
+255
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files
📢 Thoughts on this report? Let us know! |
sorami
commented
Dec 25, 2023
sorami
commented
Dec 25, 2023
sorami
commented
Dec 25, 2023
sorami
commented
Dec 25, 2023
ciscorn
reviewed
Dec 25, 2023
ciscorn
approved these changes
Dec 25, 2023
There was a problem hiding this comment.
LGTM!
Compile-time verification が使えるなら積極的に使うとよいかもなと思いましたが、Gpkgの固定テーブル以外は動的なので、あまり使い所はないかも。
https://github.com/launchbadge/sqlx?tab=readme-ov-file#compile-time-verification
This was referenced Dec 26, 2023
Closed
Closed
Closed
Closed
ciscorn
pushed a commit
that referenced
this pull request
Dec 27, 2023
#8 まず、ベースの部分を作ってみました。 このPR後に、ジオメトリデータをバイナリ化したりしたものなど、各情報をSQLiteテーブルへ入れていく。 ## 変更 - [x] `nusamai-gpkg` クレートの新規作成 - [x] SQLxによる、空のGeoPackageファイル作成 - [x] example: CLIからのテスト実行
sorami
added a commit
that referenced
this pull request
Dec 27, 2023
#89 を踏まえて、トップレベル都市オブジェクトをGeoPackageへ追加する部分を実装。 参考（Notion）: [GeoPackage メモ](https://www.notion.so/GeoPackage-56b53cc7ee5f4270a7df151d84bfb290) （テーブルやバイナリの構造など） ## 大まかな流れ - `GpkgHandler::init` (`src/handler.rs`) - `sql/init.sql` で、GeoPackage用のテーブルを作成 - `sql/mpoly3d.sql` で、3Dマルチポリゴン用のテーブルを用意 - `GpkgHandler::add_object` - トップレベル都市オブジェクトを受け取り、DBへ追加 - ジオメトリのバイナリを作る部分は `src/geometry.rs` にある exampleの実行例: ``` $ cargo run --example gml2gpkg ~/plateau/13100_tokyo23-ku_2022_citygml_1_2_op/udx/bldg/53392546_bldg_6697_2_op.gml ``` ## このPRで対応しない想定のイシュー - #119 - #120 - #121 - #122 - #124 - #125
ciscorn
added a commit
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8
まず、ベースの部分を作ってみました。
このPR後に、ジオメトリデータをバイナリ化したりしたものなど、各情報をSQLiteテーブルへ入れていく。
変更
nusamai-gpkgクレートの新規作成