new: [API] Fast check object or attribute existence by HEAD method

MISP · Nov 2, 2020 · c800470 · c800470
1 parent 557c4f5
commit c800470
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/app/Controller/AttributesController.php b/app/Controller/AttributesController.php
@@ -956,6 +956,14 @@ public function editField($id)
 
     public function view($id)
     {
+        if ($this->request->is('head')) { // Just check if attribute exists
+            $attribute = $this->Attribute->fetchAttributesSimple($this->Auth->user(), [
+                'conditions' => $this->__idToConditions($id),
+                'fields' => ['Attribute.id'],
+            ]);
+            return new CakeResponse(['status' => $attribute ? 200 : 404]);
+        }
+
         $attribute = $this->__fetchAttribute($id);
         if (empty($attribute)) {
             throw new MethodNotAllowedException(__('Invalid attribute'));

diff --git a/app/Controller/ObjectsController.php b/app/Controller/ObjectsController.php
@@ -888,6 +888,14 @@ private function __delete($id, $hard)
     public function view($id)
     {
         if ($this->_isRest()) {
+            if ($this->request->is('head')) { // Just check if object exists
+                $exists = $this->MispObject->fetchObjects($this->Auth->user(), [
+                    'conditions' => $this->__objectIdToConditions($id),
+                    'metadata' => true,
+                ]);
+                return new CakeResponse(['status' => $exists ? 200 : 404]);
+            }
+
             $objects = $this->MispObject->fetchObjects($this->Auth->user(), array(
                 'conditions' => $this->__objectIdToConditions($id),
             ));