Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation about MISP update procedure #6169

Open
dpreuveneers opened this issue Aug 3, 2020 · 1 comment
Open

Documentation about MISP update procedure #6169

dpreuveneers opened this issue Aug 3, 2020 · 1 comment
Assignees
Labels
documentation This issue involves creating or refining documentation needs documentation This issue needs documentation describing the fix T: enhancement Type: enhancement. This issue requires improving an existing feature

Comments

@dpreuveneers
Copy link

Is your feature request related to a problem? Please describe.
The documentation in https://github.com/MISP/MISP/blob/2.4/docs/UPDATE.md states that it is very strongly recommended to upgrade MISP via the web interface. This will update MISP to the latest git commit. However, I am looking for an option to update MISP to the latest point release. Option 2 in the documentation offers a way to update to the latest point release, but this may break the update procedure in the MISP web interface.

Also, the documentation of Option 2 does not consider the ownership of the files in the way that Option 1 does.

Describe the solution you'd like
Update the documentation of Option 2 to prepend the git commands with a 'sudo -u www-data' as in Option 1:

cd /var/www/MISP
sudo -u www-data git fetch
sudo -u www-data git checkout tags/$(git describe --tags `git rev-list --tags --max-count=1`)
sudo -u www-data git submodule update --init --recursive

However, doing this at the command line will still give a warning in the web interface that MISP is not on a branch. Would the following be an alternative to update MISP to the latest point release?

cd /var/www/MISP
sudo -u www-data git fetch
sudo -u www-data git merge `git rev-list --tags --max-count=1`
sudo -u www-data git submodule update --init --recursive

It seems to the job without breaking the "Update MISP" procedure in the web interface.

@dpreuveneers dpreuveneers added T: feature request Type: feature request. This issue is requesting a new feature needs triage This issue has been automatically labelled and needs further triage labels Aug 3, 2020
@iglocska
Copy link
Member

iglocska commented Aug 3, 2020

Indeed, we should label it correctly. There are two main strategies for updating your MISP:

  1. Fetch the latest tagged version and stay on that release until you decide to update
cd /var/www/MISP
sudo -u www-data git fetch
sudo -u www-data git checkout tags/$(git describe --tags `git rev-list --tags --max-count=1`)
sudo -u www-data git submodule update --init --recursive

Does exactly that.

If you want to stay on the bleeding edge:

cd /var/www/MISP
git pull origin 2.4
sudo -u www-data git submodule update --init --recursive

will do the trick.

@enjeck enjeck added documentation This issue involves creating or refining documentation needs documentation This issue needs documentation describing the fix T: enhancement Type: enhancement. This issue requires improving an existing feature and removed T: feature request Type: feature request. This issue is requesting a new feature needs triage This issue has been automatically labelled and needs further triage labels Nov 23, 2020
@enjeck enjeck self-assigned this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue involves creating or refining documentation needs documentation This issue needs documentation describing the fix T: enhancement Type: enhancement. This issue requires improving an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants