Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: [userloginprofiles] View login history page is broken on system with php version 7.4.3 #9433

Closed
1 task done
Wachizungu opened this issue Dec 7, 2023 · 2 comments
Closed
1 task done
Assignees
Labels
confirmed Anything that was previously either under investigation, potential bug, bug etc.

Comments

@Wachizungu
Copy link
Contributor

Actual behavior

image

Looks like str_contains function which is used in view_login_history.ctp is only supported as of php version 8.

Expected behavior

You can view the login history, or in case there is no support for it, you get a clean message in the GUI.

Steps to reproduce

Go to your profile and click the 'Review user logins' button.

Version

2.4.181

Operating System

Ubuntu

Operating System version

20.04

PHP version

7.4.3

Browser

No response

Browser version

No response

Relevant log output

No response

Extra attachments

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Wachizungu Wachizungu added the needs triage This issue has been automatically labelled and needs further triage label Dec 7, 2023
@cvandeplas cvandeplas self-assigned this Dec 7, 2023
@cvandeplas cvandeplas added confirmed Anything that was previously either under investigation, potential bug, bug etc. and removed needs triage This issue has been automatically labelled and needs further triage labels Dec 7, 2023
@Wachizungu
Copy link
Contributor Author

Just adding as context:
With the currently required php dependencies installed, this problem does not present itself so if you run into this issue remember to run (equivalent of the below for your system):
sudo -u www-data sh -c "cd /var/www/MISP/app;php composer.phar update"

Looks like browscap/browscap-php might be doing the trick, having symfony/polyfill-php80 in dependency tree at the moment

@cvandeplas
Copy link
Member

cvandeplas commented Dec 7, 2023

fixed, thank you for the report !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Anything that was previously either under investigation, potential bug, bug etc.
Projects
None yet
Development

No branches or pull requests

2 participants