Add support to add local tags to an event using the API. #5215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancailliau
force-pushed
the
add_localtag_api
branch
2 times, most recently
from
ee61c94
to
76c397e
Compare
app/Controller/TagsController.php
Outdated
| @@ -894,7 +894,7 @@ private function __findObjectByUuid($object_uuid, &$type) | |||
| return $object; | |||
| } | |||
|
|
|||
| public function attachTagToObject($uuid = false, $tag = false) | |||
| public function attachTagToObject($uuid = false, $tag = false, $local = 0) | |||
There was a problem hiding this comment.
Why not to use $local variable as boolean?
There was a problem hiding this comment.
Indeed, I mapped what was in the database. I'll update tomorrow with Boolean values unless someone complain :-)
ancailliau
force-pushed
the
add_localtag_api
branch
2 times, most recently
from
6a3140b
to
c65840f
Compare
ancailliau
force-pushed
the
add_localtag_api
branch
from
c65840f
to
453a54c
Compare
ancailliau
pushed a commit
to ancailliau/PyMISP
that referenced
this pull request
Sep 26, 2019
Requires MISP/MISP#5215 to be merged first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The current API does not allow users to add local tags to an event.
Questions
Release Type: