Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [REST] Python has no 'Null' type, it is called 'None' #5400

Merged
merged 3 commits into from Nov 25, 2019

Conversation

SteveClement
Copy link
Member

Wrong null type returned by generator.

@coveralls
Copy link

coveralls commented Nov 15, 2019

Coverage Status

Coverage remained the same at ?% when pulling a9a6260 on SteveClement:REST_Client_python into cfa4789 on MISP:2.4.

@Rafiot
Copy link
Member

Rafiot commented Nov 15, 2019

  1. We can probably keep PyMISP in the template, as it will be the default in ~90 days when I purge all remaining python 2.7 things
  2. Null vs. None, yes, definitely.

@iglocska iglocska merged commit 773bf7a into MISP:2.4 Nov 25, 2019
@iglocska
Copy link
Member

Thanks a lot.

@iglocska
Copy link
Member

We can already start preparing users for the switch by letting them generate expanded pymisp scripts by default. If they don't like it, they can ofc manually edit it to pymisp - there's nothing saying these scripts will be running on the same box as MISP itself so we can default to Python 3.6+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants