fix: Strip every string in AbstractMISP

fix #546
MISP · Mar 24, 2020 · b5b40ae · b5b40ae
1 parent c6656a1
commit b5b40ae
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/pymisp/abstract.py b/pymisp/abstract.py
@@ -185,6 +185,8 @@ def to_dict(self) -> dict:
                 continue
             elif isinstance(val, list) and len(val) == 0:
                 continue
+            elif isinstance(val, str):
+                val = val.strip()
             if attribute == 'timestamp':
                 if not self.__force_timestamps and is_edited:
                     # In order to be accepted by MISP, the timestamp of an object

diff --git a/tests/mispevent_testfiles/existing_event.json b/tests/mispevent_testfiles/existing_event.json
@@ -2631,7 +2631,7 @@
           "uuid": "5a3d0143-c300-4118-8afe-4a2d950d210f"
         }
       ],
-      "comment": "Win32/Sednit.AX\t",
+      "comment": "Win32/Sednit.AX",
       "deleted": false,
       "description": "File object describing a file with meta-information",
       "distribution": "5",

diff --git a/tests/mispevent_testfiles/existing_event_edited.json b/tests/mispevent_testfiles/existing_event_edited.json
@@ -2634,7 +2634,7 @@
           "uuid": "5a3d0143-c300-4118-8afe-4a2d950d210f"
         }
       ],
-      "comment": "Win32/Sednit.AX\t",
+      "comment": "Win32/Sednit.AX",
       "deleted": false,
       "description": "File object describing a file with meta-information",
       "distribution": "5",